Mark all react components as 'use client'#2943
Merged
Merged
Conversation
Member
Author
|
@jattasNI bypassing for trivial change to react components. Can address any concerns in follow-up |
Member
Author
|
Just capturing some notes, looks like for a next.js hello world one also needs to disable SSR for the Nimble components: https://blog.bitsrc.io/using-non-ssr-friendly-components-with-next-js-916f38e8992c One way is to do that on import using a next.js specific pattern, not clear to me yet if there is a more generic react server component pattern:
But with the above does seem to work: https://stackblitz.com/edit/nextjs-nimble-nossrimport?file=app%2Fpage.tsx&file=app%2Fnimble.ts |
aangerhofer
pushed a commit
that referenced
this pull request
May 27, 2026
# Pull Request ## 🤨 Rationale Nimble components rely on running client side so mark all the Nimble / Spright / Ok components with [`'use client';`](https://react.dev/reference/rsc/use-client) ## 👩💻 Implementation - Update each file and the icon build script to be marked as `use client` ## 🧪 Testing - Rely on CI to avoid regressions - Manual testing from React Server Components (RSC) and Next.JS users ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: rajsite <1588923+rajsite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request
🤨 Rationale
Nimble components rely on running client side so mark all the Nimble / Spright / Ok components with
'use client';👩💻 Implementation
use client🧪 Testing
✅ Checklist