Skip to content

Add Angular wrappers and tests for ok-components fv directives#2953

Merged
fredvisser merged 11 commits into
mainfrom
users/fvisser/fv-ok-angular-1
May 11, 2026
Merged

Add Angular wrappers and tests for ok-components fv directives#2953
fredvisser merged 11 commits into
mainfrom
users/fvisser/fv-ok-angular-1

Conversation

@fredvisser
Copy link
Copy Markdown
Contributor

Summary

Add Angular directive wrappers (ok-angular/fv/) for 9 ok-components FV web components, with comprehensive tests.

Components wrapped

  • ok-fv-accordion-item
  • ok-fv-card
  • ok-fv-chip-selector
  • ok-fv-context-help
  • ok-fv-search-input
  • ok-fv-split-button
  • ok-fv-split-button-anchor
  • ok-fv-summary-panel
  • ok-fv-summary-panel-tile

What's included

  • Angular directives mapping all public @attr properties (no @internal properties exposed)
  • NgModules with web component registration side-effect imports
  • Tests covering:
    • Custom element registration
    • Default values
    • Template string attribute binding
    • Property binding with change detection

@fredvisser fredvisser force-pushed the users/fvisser/fv-ok-angular-1 branch from 2ba29d9 to d1445a3 Compare May 11, 2026 17:31
@fredvisser fredvisser marked this pull request as ready for review May 11, 2026 17:53
@fredvisser fredvisser requested a review from jattasNI as a code owner May 11, 2026 17:53
Comment thread change/@ni-ok-components-956c8d37-d7bb-4229-b7e0-7c514b563e0e.json Outdated
Comment thread change/@ni-ok-components-956c8d37-d7bb-4229-b7e0-7c514b563e0e.json Outdated
Comment thread packages/eslint-config-nimble/ok/fv/ignore-attributes.js Outdated
Comment thread packages/eslint-config-nimble/ok/fv/ignore-attributes.js Outdated
@fredvisser fredvisser enabled auto-merge (squash) May 11, 2026 21:12
@fredvisser fredvisser merged commit 85a74e2 into main May 11, 2026
11 checks passed
@fredvisser fredvisser deleted the users/fvisser/fv-ok-angular-1 branch May 11, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants