[#1112] Make get_pin_results_pin_information() fancy #1098
Conversation
* They break codegen with 'library-only' filtering * Will be removed next time metadata updated anyway
…metadata updated to no longer have 'codegen-method': 'no' function information
…ture_waveform_u32
…ncy_get_pin_results
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 20 20
Lines 3679 3679
=======================================
Hits 3311 3311
Misses 368 368Continue to review full report at Codecov.
|
| Fields in Waveform: | ||
| - **site** (int) | ||
| - **data** (array.array of int) |
There was a problem hiding this comment.
- Is
array.array of intthe right type for the data of digital waveforms? - When I think of
WaveformI think of an analog signal by default. Should we call this DigitalWaveform or is it enough that it is annidigital.Waveform?
| '''fetch_capture_waveform | ||
| TBD | ||
| Returns a list of named tuples (Waveform) that <FILL IN THE BLANK HERE> |
There was a problem hiding this comment.
We should add an issue about <FILL IN THE BLANK HERE> unless we have another way to track it in place.
| Returns: | ||
| data (list of int): | ||
| waveform (list of Waveform): List of named tuples with fields: |
There was a problem hiding this comment.
Is the order important?
If not, it might make sense for this to be a dictionary of site->waveform data
And perhaps we should consider replacing the name tuple with the same... one less type.
|
|
||
| data, actual_num_waveforms, actual_samples_per_waveform = self._fetch_capture_waveform(site_list, waveform_name, samples_to_read, timeout) | ||
| timeout_secs = _converters.convert_timedelta_to_seconds(timeout, _visatype.ViReal64) | ||
| data, actual_num_waveforms, actual_samples_per_waveform = self._fetch_capture_waveform(site_list, waveform_name, samples_to_read, timeout_secs) |
There was a problem hiding this comment.
Why is _fetch_capture_waveform not code-generated?
The comment doesn't say so.
| ${helper.get_function_docstring(f, False, config, indent=8)} | ||
| ''' | ||
| import collections | ||
| import sys |
There was a problem hiding this comment.
Can't leave a comment on line 3
'''Dispatches to the appropriate "fetch waveform into" method based on the waveform type.'''
That seems wrong.
texasaggie97-zz
changed the title
|
Replaced by #1120 to get rid of other files |
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
get_pin_results_pin_information()PinInfo(pin_indexes, site_numbers, channel_indexes)List issues fixed by this Pull Request below, if any.
What testing has been done?