Skip to content

Move generated files #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
texasaggie97-zz merged 10 commits into from
Jan 7, 2020
Merged

Move generated files #1179

texasaggie97-zz merged 10 commits into from
Jan 7, 2020

Conversation

@texasaggie97-zz
Copy link
Contributor

@texasaggie97-zz texasaggie97-zz commented Jan 3, 2020 •
edited
Loading

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • No longer use bin and instead generate into generated files, but in the correct locations to install
    • git mv generated files to actual location
    • The hierarchy allows for installing from the generated directory whereas before, the hierarchy did not

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • Visual inspection of generated files added to git

@codecov
Copy link

codecov bot commented Jan 6, 2020 •
edited
Loading

Codecov Report

Merging #1179 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files          20       20           
  Lines        3679     3679           
=======================================
  Hits         3306     3306           
  Misses        373      373
Impacted Files Coverage Δ
generated/nifake/nifake/_attributes.py 89.55% <ø> (ø)
generated/nifake/nifake/errors.py 95.55% <ø> (ø)
generated/nifake/nifake/custom_struct.py 88.46% <ø> (ø)
generated/nifake/nifake/enums.py 100% <ø> (ø)
generated/nifake/nifake/_converters.py 94.15% <ø> (ø)
generated/nimodinst/nimodinst/session.py 95.95% <ø> (ø)
generated/nifake/nifake/_visatype.py 100% <ø> (ø)
generated/nifake/nifake/__init__.py 83.33% <ø> (ø)
generated/nitclk/nitclk/session.py 94.61% <ø> (ø)
generated/nifake/nifake/session.py 97.63% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969ceaa...d4c2f9a. Read the comment docs.

sbethur
sbethur reviewed Jan 6, 2020
View reviewed changes
marcoskirsch
marcoskirsch previously requested changes Jan 6, 2020
View reviewed changes
marcoskirsch
marcoskirsch reviewed Jan 6, 2020
View reviewed changes
@texasaggie97-zz texasaggie97-zz merged commit 5c99a91 into master Jan 7, 2020
@texasaggie97-zz texasaggie97-zz deleted the move-generated-files branch January 7, 2020 16:17
sbethur pushed a commit that referenced this pull request Jan 8, 2020
@texasaggie97-zz @sbethur
Move generated files (#1179)
f6d5974 
* Move generated files for new location

* Update .gitignore

* Use generated instead of bin

* Update generated files

* Everything is python3 now

* Additional bin -> generated

* Add comment based on review

* Updated comment based on review

* Remove unused content

* Update wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoskirsch marcoskirsch marcoskirsch approved these changes

+1 more reviewer

@sbethur sbethur sbethur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@texasaggie97-zz @marcoskirsch @sbethur