Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Jan 8, 2020

- [ ] I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Add tests for get_pin_results_pin_information. This method was made "fancy" in Python:

  • Instead of returning pin indices, we call get_pin_name and return pin names
  • Instead of returning channel numbers (int), we return fully-qualified channel names
  • Instead of returning 3 different arrays (as in C API), we return a list of collections.namedtuple('PinInformation', ['pin_name', 'site_number', 'channel_name'])

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Ran tests

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1187   +/-   ##
======================================
  Coverage    95.1%   95.1%           
======================================
  Files          10      10           
  Lines        1655    1655           
======================================
  Hits         1574    1574           
  Misses         81      81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa1df2...19f1062. Read the comment docs.

@marcoskirsch marcoskirsch merged commit 309c2ca into master Jan 15, 2020
@marcoskirsch marcoskirsch deleted the nidigital_get_pin_results_pin_info_test branch January 15, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants