Remove redundant methods from the nidigital API #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConfigureCycleNumberHistoryRAMTrigger ConfigureDigitalEdgeConditionalJumpTrigger ConfigureDigitalEdgeStartTrigger ConfigureFirstFailureHistoryRAMTrigger ConfigureHistoryRAMCyclesToAcquire ConfigurePatternLabelHistoryRAMTrigger ConfigureSoftwareEdgeConditionalJumpTrigger ConfigureSoftwareEdgeStartTrigger ConfigureStartLabel ConfigureTerminationMode DisableConditionalJumpTrigger DisableStartTrigger FrequencyCounter_ConfigureMeasurementTime PPMU_ConfigureApertureTime PPMU_ConfigureCurrentLevel PPMU_ConfigureCurrentLevelRange PPMU_ConfigureCurrentLimit PPMU_ConfigureCurrentLimitRange PPMU_ConfigureOutputFunction PPMU_ConfigureVoltageLevel PPMU_ConfigureVoltageLimits SelectFunction Operations performed by these methods can be done using properties
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
======================================
Coverage 95.1% 95.1%
======================================
Files 10 10
Lines 1655 1655
======================================
Hits 1574 1574
Misses 81 81Continue to review full report at Codecov.
|
marcoskirsch
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Methods removed:
Operations performed by these methods can be done using properties.
List issues fixed by this Pull Request below, if any.
What testing has been done?
Through code inspection, verified that these methods call corresponding properties internally.