-
Notifications
You must be signed in to change notification settings - Fork 0
Add more samples, to make testing with multiple panels easier. #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some documentation suggestions to replace passive voice with active voice.
Johann is out of office, and Joe is taking his role for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider updating (or deleting) the screenshots in the PR description or moving them as assets for the readmes so users can know whether "they got it working" correctly.
Food for thought later on...
- In the logic script, we call
create_panel()and store the retval in a variable namedpanel - In the visualization script, we call
initialize_panel()and store theretvalin a variable namedpanel - But the
panels are not the same class
One impression a reader may have is "I should call create, and then call initialize," but that would put them on a confusing path. Perhaps we can use create_visualization() or similar rather than initialize_panel() to hint that these functions are not meant to be used together in the same file.
What does this Pull Request accomplish?
This just adds two more samples, for a total of three.
Why should this Pull Request be merged?
This will make it easier to test with multiple panels.
What testing has been done?
I tested by running all three panels at the same time: