Add unit tests for _convert.to_any() and _convert.from_any() #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2025 12:52
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
mikeprosserni
approved these changes
Jun 19, 2025
jfriedri-ni
approved these changes
Jun 19, 2025
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
reviewed
Jun 19, 2025
| @@ -0,0 +1,131 @@ | |||
| from typing import Any, Type, Union | |||
There was a problem hiding this comment.
typing.Type is no longer needed in Python 3.9+, use type[T] instead.
| # ======================================================== | ||
| # Pack/Unpack Helpers | ||
| # ======================================================== | ||
| def _assert_any_and_unpack(packed_message: any_pb2.Any, unpack_destination: Any) -> None: |
There was a problem hiding this comment.
FYI, a more precise type for unpack_destination would be Message (i.e. google.protobuf.message.Message).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds unit tests for
_convert.to_any()and_convert.from_any()Why should this Pull Request be merged?
Since we are going to be adding more protobuf types (Scalar, Analog Waveform, etc.) to this _convert file soon, having unit tests is a good way to try and prevent breakages for existing functionality.
What testing has been done?
pytest, mypy, styleguide