Skip to content

Conversation

@dixonjoel
Copy link
Collaborator

@dixonjoel dixonjoel commented Sep 26, 2025

What does this Pull Request accomplish?

Checks for whether mypy and pyright are installed were incorrectly using the installed Python instead of the python in the venv of the project we're analyzing.

Fixes #31

Why should this Pull Request be merged?

Analyze-project isn't running mypy and pyright.

What testing has been done?

On the PR checks, I can see it is now getting 'true' and 'true' for whether pyright and mypy are installed and running those checks.

@dixonjoel dixonjoel changed the title Run the python checks for mypy and pyright on the Python the project … Fix analyze-project where it decides if mypy and pyright are installed Sep 26, 2025
@dixonjoel dixonjoel marked this pull request as ready for review September 26, 2025 15:59
@dixonjoel dixonjoel merged commit 36f9be5 into main Sep 26, 2025
111 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/fix-analyze-project branch September 26, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ni/python-actions/analyze-project does not think mypy is installed

4 participants