Skip to content

Reject flake8-commas #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2021
Merged

Reject flake8-commas #51

merged 2 commits into from
Feb 23, 2021

Conversation

@thejcannon
Copy link
Contributor

This plugin is all about trailing commas, which black already handles.: https://github.com/PyCQA/flake8-commas/

@thejcannon thejcannon requested a review from neilvana as a code owner February 17, 2021 20:31
@thejcannon thejcannon merged commit 3e074d8 into ni:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilvana neilvana neilvana approved these changes

@irwand irwand irwand approved these changes

@mshafer-NI mshafer-NI mshafer-NI approved these changes

+2 more reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

@rick-morrow rick-morrow rick-morrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thejcannon @rtzoeller @neilvana @irwand @rick-morrow @mshafer-NI