Skip to content

Conversation

@mshafer-NI
Copy link
Collaborator

Found that Unicode symbols in code files broke acknowledge code

@mshafer-NI
Copy link
Collaborator Author

High level of change:

  • bump pyproject.toml [too.poetry.dev-dependencies] pytest-snapshot from 0.4.2 to 0.6.3 or greater (utf-8 default was added in 0.5, and 0.6 added binary support, but had a bug fixed in 0.6.1, so requiring those fixed versions at minimum, but not pinning due to semantic versioning considering a 0.x bump to be a major bump)
  • Add test case with (U+201D) - this was failing case that prompted investigation
  • default acknowledge_existing_errors to use UTF-8 for reads and writes

@mshafer-NI mshafer-NI merged commit 9701e2f into ni:main Oct 20, 2021
@mshafer-NI mshafer-NI deleted the suppression_handle_unicode_files branch October 20, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants