Skip to content

Suppression handle unicode files #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Suppression handle unicode files #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6284123
bump tests to enable testing
mshafer-NI Oct 19, 2021
f43d167
make a failing test
mshafer-NI Oct 19, 2021
0efa046
make it pass
mshafer-NI Oct 19, 2021
0166111
format
mshafer-NI Oct 19, 2021
e1b3af7
reset black version config - not really related
mshafer-NI Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ni_python_styleguide/_acknowledge_existing_errors/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
"BLK100",
}

DEFAULT_ENCODING = "UTF-8"


class _InMultiLineStringChecker:
def __init__(self, error_file):
Expand All @@ -27,7 +29,7 @@ def _count_multiline_string_endings_in_line(line):
return line.count('"""'), line.count("'''")

def _load_lines(self):
in_file = self._error_file.read_text().splitlines()
in_file = self._error_file.read_text(encoding=DEFAULT_ENCODING).splitlines()
current_count = [0, 0]
for line in in_file:
type1, type2 = _InMultiLineStringChecker._count_multiline_string_endings_in_line(line)
Expand Down Expand Up @@ -73,7 +75,7 @@ def acknowledge_lint_errors(lint_errors):

for bad_file, errors_in_file in lint_errors_by_file.items():
path = pathlib.Path(bad_file)
lines = path.read_text().splitlines(keepends=True)
lines = path.read_text(encoding=DEFAULT_ENCODING).splitlines(keepends=True)
# sometimes errors are reported on line 1 for empty files.
# to make suppressions work for those cases, add an empty line.
if len(lines) == 0:
Expand Down Expand Up @@ -110,4 +112,4 @@ def acknowledge_lint_errors(lint_errors):
explanation=error.explanation,
)

path.write_text("".join(lines))
path.write_text("".join(lines), encoding=DEFAULT_ENCODING)
Loading