Add workflows to sign container images and helm charts #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We should squash this pull request. It has a lot of noise. |
irwand
approved these changes
Mar 3, 2022
.github/workflows/sign-container.yml
Outdated
| env: | ||
| GNUPGHOME: ${{ runner.temp }}/gpg | ||
| - name: List keys | ||
| run: gpg --list-secret-keys |
Collaborator
There was a problem hiding this comment.
this is only for debugging so can be deleted?
Collaborator
Author
There was a problem hiding this comment.
You are correct. I'll remove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds new reusable workflows and documentation to sign container images and helm charts published to Artifactory.
Why should this Pull Request be merged?
We need these features to enable delivering signed containers and helm charts to our customers. These workflows will enable adding signing to many different repos without having to reimplement the logic.
What testing has been done?
These reusable workflows have been tested from another repo. See the workflow run here:
https://github.com/neilvana/signing-dev/actions/runs/1925257319