Improve grep perf planning, benchmarks, and ordered emission#30
Merged
Improve grep perf planning, benchmarks, and ordered emission#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmarks
Criterion comparison between the benchmark baseline commit
c067e96and the refactor commitc79f61b:patterns_double_star_match: 15.389 ns -> 15.671 nswalk_ignore_and_filter_only: 917.15 us -> 940.71 ussearch_sorted_sparse_file_list: 9.1030 ms -> 9.4201 mswalk_and_search_dense_tree: 15.078 ms -> 14.999 msExternal
hyperfinerun on/System/Libraryfrom the current branch release binary:tgrep: 18.273 s./target/release/tgrep: 12.939 sTesting
cargo testcargo bench --no-runcargo bench --bench patterns -- --noplot