Nxt 601 add v2 endpoint#366
Merged
beccadawson merged 2 commits intoNXT-601-upgrade-to-v-2-of-storyblok-apifrom Apr 30, 2025
Merged
Nxt 601 add v2 endpoint#366beccadawson merged 2 commits intoNXT-601-upgrade-to-v-2-of-storyblok-apifrom
beccadawson merged 2 commits intoNXT-601-upgrade-to-v-2-of-storyblok-apifrom
Conversation
beccadawson
changed the base branch from
NXT-601-upgrade-to-v-2-of-storyblok-api-update-mocks
to
NXT-601-upgrade-to-v-2-of-storyblok-api
johndavey72
approved these changes
Apr 30, 2025
lizaadebowale
pushed a commit
that referenced
this pull request
May 21, 2025
* NICE-448 Update storyblok API version to V2 Co-authored-by: beccadawson <beccadawson@users.noreply.github.com> Co-authored-by: John Davey <johndavey72@users.noreply.github.com> * NICE-448 Update category landing mock data with response from API V2 and add request url to file for ease of updating * NICE-448 Update mock homepage story data with V2 response and add reference request URL * NICE-448 move comments with API URLs for mock data out of JSON files into relevant test files to avoid invalid JSON errors * NICE-448 Update mock data for single story and single blog post and document queries used * NICE-448 Update blog catchall page tests and storyblok utils tests to reflect updated shape of mock data * NXT-601 Update single blog post mock data and update snapshot, fix incorrect changes to remove data object from response shape, update note for how to generate mock data * NXT-601 global replace real storyblok image paths with fake paths and update (except StoryblokImage where comment is added to explain need for real path) * NXT-601 Add TODOs for mock data missed in first sweep * NXT-601 Add ocelotEndpointV2 to mock publicRuntime config * Nxt 601 add v2 endpoint (#366) https://nicedigital.atlassian.net/browse/NXT-601 * NXT-601 Add new v2 ocelot endpoint to config and update calls * NXT-601 update default.yaml to use new v2 endpoint * NXT-601 add missing data object to Storyblok single story mock data * NXT-601 fix incorrectly changed image path note in StoryblokImage component * NXT-601 Add missing data object back to SB Utils FetchStory test * NXT-602 update DownsteamPathTemplate to v2 * NXT-602 update startup.cs segment match * NXT-602 revert match on segment to contains matcher * NXT-602 Remove cv value mutation from Ocelot pipeline * NXT-602 Fix 404 error * NXT-602 Remove cv mutation from pipeline * NXT-601 update homepage story mocks to use resolved realtions * NXT-601 Update storyblok types from LIVE * NXT-601 add missing property to mock data * NXT-601 remove import * NXT-601 add fetchCacheVersion to storyblok utils - first pass * NXT-601 Pass cache version value to fetcLinks API * NXT-601 Update testcases to cover fetchCacheVersion API-WIP * NXT-601 Add Mock FetchCacheVersion in unit test cases * NXT-601 Move fetchCacheVersion globally to jest.setup * NXT-601 update page gssp test to include spy on fetchCachedVersion function * NXT-601 fix linting * NXT-601 Fix lint issues * NXT-601 test removing steps from home.feature click link to new page * NXT-601 functional test, scroll news link into view before click * NXT-601 revert functional test for scroll news link into view * NXT-601 test scrollintoView for news link without initial scroll depth of 900 * NXT-601 add logger info for cv value * NXT-601 lint fix logger * NXT-601 update initStoryblok and logs to revert back to ocelotEnpoint over ocelotEndpoitnV2 * NXT-601 fix lint warn * NXT 601: Fix scrolling issue on feature test by introducing scrolling operation using x and y coordinates * NXT-601 Update mock data for MockMultipleStorySuccessResponse Co-authored-by: Shilpa Unni <shilpanice@users.noreply.github.com> Co-authored-by: beccadawson <beccadawson@users.noreply.github.com> * NXT-601 Remove TODO for 404 mock * NXT-601 remove commented code and update cache version variable * NXT-601 remove remaining mock data TODOs * NXT-601 update SB types from Live space * NXT-601 update tests to use centralised cv value mock * NXT-601 lint fix * NXT-601 add logs for CV value on SB API requests * NXT-601 lint fix * NXT-601 update snapshots from updated mock data * NXT-601 updte outofbounds pagination logic from mock update. * NXT-601 update logs for fetchcache and fetchStory * NXT-601 lint fix * NXT-601 fix logger test after log output update * NXT-601 lint fix * NXT-601 update test and lint fix * NXT-601 revert jest setup extension to .ts * NXT-601 update file path in jest.config --------- Co-authored-by: Shilpa Unni <shilpa.unni@nice.org.uk> Co-authored-by: beccadawson <beccadawson@users.noreply.github.com> Co-authored-by: John Davey <johndavey72@users.noreply.github.com> Co-authored-by: John Davey <john.davey@nice.org.uk> Co-authored-by: Dale H <dale.hudson@nice.org.uk> Co-authored-by: Colin M <12713935+colinmazu@users.noreply.github.com> Co-authored-by: FunmiOsho <60607637+FunmiOsho@users.noreply.github.com> Co-authored-by: Shilpa Unni <shilpanice@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nicedigital.atlassian.net/browse/NXT-601