Add ApplyPtr and DiffPtr methods to Update[T] #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansharman
commented
Jul 8, 2022
| t.Errorf("Error unmarshaling JSON: %s", err) | ||
| } | ||
| if !reflect.DeepEqual(dst.Update, testCase.expected) { | ||
| if !dst.Update.Equal(testCase.expected) { |
Contributor
Author
There was a problem hiding this comment.
Might as well use the built-in method.
wmarshall
requested changes
Aug 24, 2022
Contributor
wmarshall
left a comment
wmarshall
left a comment
There was a problem hiding this comment.
not hard requested changes, mostly questioning aliasing
Co-authored-by: Will Marshall <willcodymarshall@gmail.com>
wmarshall
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
ApplyPtrandDiffPtrmethods, which are similar toApplyandDiffexcept that they take a pointer and returnnilif the operation isRemove, rather thanT's zero value.Testing Considerations
Will be tested via https://github.com/nicheinc/fact/pull/301 (private to
nicheinc).Versioning
Minor.