feat: add batchFind* methods to edge collections for store.batch()#52
Merged
Conversation
Edge collection lookups (findFrom, findTo, findByEndpoints) execute immediately and cannot participate in store.batch(). Add deferred variants — batchFindFrom, batchFindTo, batchFindByEndpoints — that return BatchableQuery for single-connection batched execution.
466dd46 to
14f61ff
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batchFindFrom,batchFindTo, andbatchFindByEndpointsto edge collections, returningBatchableQueryfor use withstore.batch()@ts-expect-error+ tsd declaration tests) verifying endpoint constraints and return typesMotivation
Edge collection lookups (
findFrom,findTo,findByEndpoints) execute immediately and can't participate instore.batch(). This forces users to rewrite simple edge lookups as verbose fluent traverse queries to batch them. The newbatchFind*variants close this gap.Closes #51