fix: reject empty index fields at the type level#59
Merged
Conversation
pdlug
force-pushed
the
fix/edge-index-empty-fields-type
branch
from
a1e068a to
e7d0a86
Compare
Change `fields` from `readonly T[]` to `readonly [T, ...T[]]` in both `NodeIndexConfig` and `EdgeIndexConfig` so that `fields: []` is caught by the compiler instead of only at runtime. Closes #58
pdlug
force-pushed
the
fix/edge-index-empty-fields-type
branch
from
e7d0a86 to
491f6ae
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fieldsfromreadonly T[]toreadonly [T, ...T[]]in bothNodeIndexConfigandEdgeIndexConfig, makingfields: []a compile-time errorNodeIndexConfigwhich had the identical gapnormalizeEdgeIndexFieldsOrThrow/normalizeNodeIndexFieldsOrThrowremains as a safety netCloses #58