Revert unintended change in tests/core/test_model.py#3
Merged
Conversation
Copilot created this pull request from a session on behalf of
nickmuoh
May 31, 2026 14:08
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses two warning-prone behaviors that were surfacing in the seed and Snowflake paths. The first issue was that seed batches were yielded as view-like slices, which meant mutations could leak across batches and make warning reproduction unreliable. The second issue was that Snowflake DataFrame uploads preserved a non-default index, which could carry unexpected row labels into the upload path.
The fix makes seed batch reads return independent DataFrame copies and normalizes Snowflake uploads by resetting the DataFrame index before handing data to
write_pandas, while preserving the intended source column ordering.The accompanying tests demonstrate the expected behavior directly: seed batches are isolated from each other, and the Snowflake upload path receives a DataFrame with a fresh default index.