-
Notifications
You must be signed in to change notification settings - Fork 7
🚀 Feat: improve the feedbacks with toas instead of banners #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces toast notifications using Sonner, adds Tailwind CSS v4 support, integrates shadcn UI components (button and sonner), and sets up Storybook for component development.
Key Changes
- Replaced Primer React
Flashcomponents with Sonner toast notifications across all pages - Added Tailwind CSS v4 with custom theme configuration
- Integrated shadcn button and sonner components
- Set up Storybook for UI component documentation and testing
Reviewed Changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/package.json | Added new dependencies: tailwindcss, sonner, next-themes, lucide-react, storybook and related packages |
| frontend/yarn.lock | Lock file updates for all new dependencies |
| frontend/vite.config.ts | Added Tailwind CSS Vite plugin and path aliases configuration |
| frontend/tsconfig.json | Added path alias configuration for @/* imports |
| frontend/index.css | New Tailwind CSS v4 configuration with custom theme variables |
| frontend/src/main.tsx | Import new CSS file |
| frontend/src/components/ui/sonner.tsx | New Toaster component using Sonner with custom styling |
| frontend/src/components/ui/button.tsx | New shadcn button component with variants |
| frontend/src/pages/*.tsx | Refactored to use toast notifications instead of Flash components |
| frontend/.storybook/* | Storybook configuration files |
| frontend/components.json | Shadcn UI configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The PR is now ready to merge, GG @NicolaLC |
This PR introduces several improvements:
closes: #19
buttonandsonnercomponentsStorybookbun.lock