-
Notifications
You must be signed in to change notification settings - Fork 7
📐 Refactor: best practice file + dismiss website + agent code helper #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicofretti
merged 21 commits into
develop
from
30-refactor-best-practice-file-dismiss-website
Nov 15, 2025
Merged
📐 Refactor: best practice file + dismiss website + agent code helper #36
nicofretti
merged 21 commits into
develop
from
30-refactor-best-practice-file-dismiss-website
Nov 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add logging to registry for failed module imports - split long functions in structured_generator, text_generator, markdown_multiplier - add error handling to llm api calls - refactor config schema generation for readability - all functions now under 30 lines - all tests passing
- add logging to storage.py for transaction failures - fix blocking I/O in job_processor.py using asyncio.to_thread - remove silent failures in job_processor.py (file deletion, async shutdown) - add logger.exception() to all exception handlers - preserve stack traces in workflow.py and template_renderer.py - all tests passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
make formatpassesmake pre-mergepasses