Skip to content

fix: split display path and query base path#714

Draft
nicotsx wants to merge 2 commits intomainfrom
03-26-fix_split_display_path_and_query_base_path
Draft

fix: split display path and query base path#714
nicotsx wants to merge 2 commits intomainfrom
03-26-fix_split_display_path_and_query_base_path

Conversation

@nicotsx
Copy link
Copy Markdown
Owner

@nicotsx nicotsx commented Mar 26, 2026

Closes #709

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68c3c7e6-2f8a-4100-a8bf-06372eb41294

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

nicotsx commented Mar 26, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nicotsx nicotsx marked this pull request as ready for review March 26, 2026 18:31
@nicotsx
Copy link
Copy Markdown
Owner Author

nicotsx commented Mar 26, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4020c536c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}
return kinds;
}, [fileBrowser.fileArray]);
const displayFileArray = fileBrowser.fileArray.map((entry) => ({ ...entry, path: toDisplayPath(entry.path) }));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add missing ancestor nodes after remapping display paths

When queryBasePath is a descendant of displayBasePath, this remap turns entries like /child into /subdir/child but does not materialize the new ancestor (/subdir) in the list. useFileBrowser already drops the query root entry, so FileTree ends up with no root-level nodes and renders an empty browser for snapshots whose base paths differ (for example, include-path snapshots shown against a volume root). That makes restore/download selection impossible in that flow.

Useful? React with 👍 / 👎.

@nicotsx nicotsx force-pushed the 03-26-fix_split_display_path_and_query_base_path branch from 4020c53 to 187030d Compare March 26, 2026 20:03
@nicotsx nicotsx force-pushed the 03-26-fix_split_display_path_and_query_base_path branch from 187030d to 28d5c05 Compare March 26, 2026 22:33
@nicotsx nicotsx marked this pull request as draft March 26, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Oldest snapshot empty, "No files in this snapshot"

1 participant