Skip to content

pump status and receivers for SMS reply option#2258

Closed
justmara wants to merge 1 commit intonightscout:devfrom
justmara:fix/sms-communicator-long-messages
Closed

pump status and receivers for SMS reply option#2258
justmara wants to merge 1 commit intonightscout:devfrom
justmara:fix/sms-communicator-long-messages

Conversation

@justmara
Copy link
Copy Markdown

@justmara justmara commented Dec 5, 2022 •
edited
Loading

fixes #2257

  1. made pump status optional in successful reply messages. by default it is added to keep current behaviour unchanhed
  2. added an option to send successful reply messages only to comand sender. defaults to false to maintain current behaviour

@justmara justmara force-pushed the fix/sms-communicator-long-messages branch from 814a64e to c6e891d Compare December 6, 2022 06:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 28 Bugs
Vulnerability D 5 Vulnerabilities
Security Hotspot E 57 Security Hotspots
Code Smell A 2666 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@MilosKozak
Copy link
Copy Markdown
Contributor

MilosKozak commented Aug 17, 2023

@justmara
generaly i'm against adding more options for non important things. there are too much already and this makes AAPS hard to setup
But i'd accept configuration via file in extra directory

@MilosKozak MilosKozak closed this Oct 28, 2023
@justmara justmara mentioned this pull request Jan 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justmara @MilosKozak