insulin_concentration bug_fix #4439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Philoul this has a conflict now |
This reverts commit 3c94543.
…Todo/insulin_concentration_bug_fix
|
MilosKozak
merged commit 922511b
into
nightscout:insulin_concentration
2 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detailedBolusInfo.id)Fix missing convertions in PumpWithConcentration(I finally propose to replace Double by PumpInsulin)Note that we still miss in EventOverviewBolusProgress the convertion of
deliveredvalue currently sent asDoublefrom pump driver and not sent asPumpInsulinDoublevalue byPumpInsulinvalue in EventOverviewBolusProgress constructor and provide concentration to manage convertion CU -> IU included in PumpInsulin object to fix BolusProgressDialog withdeliveredsent...My plan is to use ch (concentrationHelper) for everything related to userInterface (at least to provide concentration to be able to manage convertion and standardize presentation everywhere...