external insulin to the bolus shortcuts.

[avouspierre]

Add toggle for external insulin to shortcut action #528.

Behavior

If toggle, the Insulin will be added to IOB but it will not be delivered.
Not dependant of the settings configuration about the bolus available in shortcuts but maxBolus is checked.
Translation is available

English	French

[kingst]

the code LGTM and I tested it on the simulator -- it appears to be working

[dnzxy]

The code generally looks good to me and it works (tested in-vitro).
I have two change requests:

1. External insulin when added in-app via treatment view is guarded by maxBolus x 3. Here we would allow any number. Please apply the same max bound check and an appropriate error, if a user attempts to enter say 5x max bolus insulin.
2. I would change the wording from "immediately applying" to something that conveys the nature of "you log this, but the pump does nothing, you have to inject / take the dose" in a more intuitive way. In the app we call this "Log External Insulin". Maybe using that phrase (once as a question "How much external insulin do you want to log?", once as a statement "Logging xxx U of external insulin.") may be clearer for users.

[dnzxy]

Hi @avouspierre. Are you able to take a look at this PR anytime soon? If not, does someone else maybe want to take over and collaborate with Pierre? Maybe @dsnallfot or @bjorkert ?

[avouspierre]

HI @dnzxy ,

Lately but a update of this PR with :

• add guardrail about max bolus if external insulin as Trio (3 x max bolus)
• change the label "apply" ➡️ "log" when external insulin.

[marv-out]

Please solve the merge conflicts, add the missing "n" (see comment in BolusIntentRequest) and add a condition to the confirmation message that clearly distinguishes between the logging of external insulin and bolusing actual insulin. Currently if you enable the confirmation message for logging external insulin it also says "Are you sure to bolus x U of insulin"

So in fact two minor changes, then this is good to go 🚀