fix: statistics summaries not calculating on initial view load#698
Merged
dnzxy merged 1 commit intonightscout:devfrom Aug 11, 2025
Merged
Conversation
…l view load - Add DispatchQueue.main.async to defer summary calculations in onAppear - Use MainActor.run for onChange(of: selectedInterval) to ensure scroll position updates before calculations - Applies to MealStatsView, BolusStatsView, and TotalDailyDoseChart - Fixes issue where summaries showed 0 until user interacted with chart
Sjoerd-Bo3
requested review from
AndreasStokholm,
MikePlante1,
bjornoleh,
dnzxy,
marv-out and
t1dude
as code owners
Sjoerd-Bo3
changed the title
Contributor
|
Tested on TDD, now no fine tuning is needed anymore for the daily stats. It is aligned on full current day on first popup. |
dnzxy
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Related to #687 - this addresses the secondary timing issue discovered during testing.