Adding new nodes probably breaks spacings

[TomasVotruba]

Hi!

I'm performing transformating from Pseudo_Namespace to Namespace (basically inversion of your tutorial).

And I need to add Namespace_ node in afterTraverse() method.

All works fine, node is added on right position. But issue is, all spaces are wiped.

In examples:

Before

<?php declare(strict_types=1);

class PHPUnit_TestCase
{
}

After

<?php

declare(strict_types=1);
namespace PHPUnit; // this line was added!
class TestCase
{
}

• Here is how I'm adding Namespace_ token

• Here is input file

• Here is output file:

---

• Here is expected output file

• Here is NodeVisitor performing the transformation

[nikic]

Support for this has been implemented only recently, can you try updating the commit hash in https://github.com/RectorPHP/Rector/blob/master/composer.json#L13? ed8a744 does not yet have it.

[TomasVotruba]

Yep, it works, thank you.

I have problems to understand this node nulling.

$node->setAttribute('origNode', null);

Sometimes it's needed to make things work. It's too random for me now. Is there any explanation that could help me?

[nikic]

@TomasVotruba $node->setAttribute('origNode', null) is needed if you explicitly don't want to preserve formatting for a node. Normally it shouldn't be necessary unless you need to work around a bug. In what circumstances do you use it?

[TomasVotruba]

There are 5 places at the moment: https://github.com/RectorPHP/Rector/search?utf8=%E2%9C%93&q=-%3EsetAttribute%28Attribute%3A%3AORIGINAL_NODE%2C+null%29&type=

I get this error over and over again, if not used at those places: https://travis-ci.org/RectorPHP/Rector/builds/288741165#L622

[nikic]

@TomasVotruba The problem is that the added statements use keys like before_2, while list nodes are expected to be indexed numerically. In StatementGlue::insertBefore, replacing the implementation with something like array_splice($classNode->stmts, $key, 0, [$node]) should work.

[TomasVotruba]

@nikic String keys was old hack to make this work. array_splice works like a charm, thank you.
I could remove 3 cases of nulling origNode: rectorphp/rector@cf20829

Only 2 cases related to Namespace_ node remains:

• https://github.com/RectorPHP/Rector/blob/fba26692b87800e132aa94417dec433936bd792a/src/Rector/Dynamic/NamespaceReplacerRector.php#L72
• https://github.com/RectorPHP/Rector/blob/0b5126c4b9496011c6e5942189eb1acb000733a4/src/Rector/Dynamic/PseudoNamespaceToNamespaceRector.php#L93

[nikic]

@TomasVotruba Should be fixed by f5de7f9. Please check if updating php-parser resolves this problem.

[TomasVotruba]

@nikic It works 👏 Thanks man
rectorphp/rector@c268b37

I wonder, will be comments for these nodes be available in printing?