Conversation
Account for GitHub giving precedence to the latest review - only if the last review per valid reviewer is approved, then the pull request is approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
While on the board we already computed the effective review state and indicated on a card, we did not do the same thing for
is:reviewedandis:approvedfilters: An issue that wasapprovedearlier, and thenchanges_requestedby the same user would still hold the "approved" stamp.This PR fixes the behavior - mirroring GitHub giving precedence to the latest review - only if
the last review per valid reviewer is approved, then the pull request is approved.