Skip to content

memory limit#29

Merged
niklabh merged 1 commit into
mainfrom
fix/gpui-migration-bugs-and-docs
Apr 11, 2026
Merged

memory limit#29
niklabh merged 1 commit into
mainfrom
fix/gpui-migration-bugs-and-docs

Conversation

@niklabh
Copy link
Copy Markdown
Owner

@niklabh niklabh commented Apr 11, 2026

Summary by CodeRabbit

Release Notes

  • Improvements

    • Expanded default sandbox memory capacity from 16MB to 256MB, enabling enhanced resource allocation and improved runtime performance for complex applications
    • Refined camera capture format to standard 1280x720 resolution for improved device compatibility
  • Documentation

    • Updated host environment documentation to reflect the new 256MB maximum memory limit
  • Chores

    • Updated sample video source URL

@niklabh niklabh merged commit 1839b69 into main Apr 11, 2026
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 11, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd83600b-a965-49dd-a912-cc77041ac2d8

📥 Commits

Reviewing files that changed from the base of the PR and between 6e587bb and 21a2a82.

📒 Files selected for processing (4)
  • examples/video-player/src/lib.rs
  • oxide-browser/src/engine.rs
  • oxide-browser/src/lib.rs
  • oxide-browser/src/media_capture.rs

📝 Walkthrough

Walkthrough

This pull request updates configuration constants and documentation across two oxide-browser components and one example file. A sample video URL is updated to a different CDN, the default sandbox memory limit is increased from ~16MB to ~256MB with corresponding documentation changes, and the camera capture format selection is changed to explicitly target 1280×720 resolution instead of absolute highest resolution.

Changes

Cohort / File(s) Summary
Example Updates
examples/video-player/src/lib.rs
Updated sample MP4 URL constant from file-examples.com to cloudfront.net endpoint.
Oxide-browser Sandbox Configuration
oxide-browser/src/engine.rs, oxide-browser/src/lib.rs
Increased default sandbox linear-memory cap from 256 pages (~16 MiB) to 4096 pages (~256 MiB) via MAX_MEMORY_PAGES constant update; updated host runtime documentation to reflect new 256MB maximum memory limit.
Oxide-browser Media Capture
oxide-browser/src/media_capture.rs
Modified camera format selection from RequestedFormatType::AbsoluteHighestResolution to explicit RequestedFormatType::HighestResolution(Resolution::new(1280, 720)) targeting 720p resolution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 Bigger buffers, cleaner schemes,
From sixteen to two-fifty streams,
Pixels aligned at 720 deep,
Constants tuned for tasks to keep,
As our code hops ever on! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gpui-migration-bugs-and-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant