improve(replay): set-speed default title should match configured speed (#295)#299
Conversation
Pass the formatted speed label (e.g., "4x", "1/2x") as the default title instead of the static "SET SPEED" text, so users can tell at a glance which speed the button will activate. Closes #295
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe default title for the "set-speed" replay control mode now dynamically reflects the configured speed (e.g., "4x", "1/4x") instead of always displaying "SET SPEED". Test assertions verify the new dynamic behavior and confirm the static text is no longer present. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
"4x","1/2x") as the default title for set-speed mode instead of the static"SET SPEED"text<desc>title metadata in the set-speed SVG to prevent fallback to old static text"SET SPEED"Closes #295
Test plan
npx vitest run packages/actions/src/actions/replay-control.test.ts— 102 tests passpnpm build— succeedsSummary by CodeRabbit