ci(release): opt Firebase deploy into Node 24 (#388)#628
Conversation
ci(release): opt Firebase deploy into Node 24 (#388) FirebaseExtended/action-hosting-deploy@v0 still declares `using: node20`, which GitHub has deprecated: Node 20 actions are forced to Node 24 from 2026-06-02 and Node 20 is removed from runners on 2026-09-16. Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true on the deploy job so the action runs under Node 24 ahead of the forced cutover. This is a holding fix; remove it once upstream ships a Node 24 release (tracked in #388). @
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the Firebase Hosting release workflow to opt into Node 24 for JavaScript actions ahead of GitHub's June 2026 deadline, validating the hosted deployment action's compatibility before the forced transition. ChangesNode 24 Compatibility Testing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@ |
|
Tip For best results, initiate chat on the files or code changes.
✏️ Learnings added
|
@
Related Issue
Fixes #388
What changed?
FirebaseExtended/action-hosting-deploy@v0still declaresusing: node20in itsaction.yml, which GitHub has deprecated. Node 20 JavaScript actions are forced to Node 24 starting 2026-06-02, and Node 20 is removed from runners on 2026-09-16.This sets
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueon thebuild_and_deployjob in.github/workflows/firebase-hosting-release.yml, opting the deploy into Node 24 ahead of the forced cutover. It is the holding fix recommended in the issue (option 2). The third-party action stays in place; if upstream has not shipped a Node 24 release by ~August 2026, we can migrate to deploying viafirebase-toolsdirectly (option 3) — it is already a devDependency.How to test
This workflow only runs on
workflow_dispatchorworkflow_call(fromrelease.yml) and deploys to the live channel, so it cannot be exercised from a PR without triggering a real production deploy. Verification happens at the next release: the "Node.js 20 actions are deprecated" annotation should no longer appear, and the deploy step should run under Node 24.Checklist
@
Summary by CodeRabbit