Skip to content

lon: add --continue-on-error flag to the update subcommand#67

Open
SolidEva wants to merge 1 commit into
nikstur:mainfrom
SolidEva:update-continue-on-error
Open

lon: add --continue-on-error flag to the update subcommand#67
SolidEva wants to merge 1 commit into
nikstur:mainfrom
SolidEva:update-continue-on-error

Conversation

@SolidEva
Copy link
Copy Markdown

by default the update subcommand does not update any sources if a single source fails
this is annoying when the lockfile contains a source that is expected to fail, like a local repo that isn't present on the current host

by default the update subcommand does not update any sources if a single
source fails
this is annoying when the lockfile contains a source that is expected to
fail, like a local repo that isn't present on the current host
Comment thread rust/lon/src/cli.rs
/// Whether to continue to try to update sources
/// when a source fails to update.
#[arg(short, long, default_value_t = false)]
continue_on_error: bool,
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picked this name rather arbitrarily, open to better suggestions

@SolidEva
Copy link
Copy Markdown
Author

ah, i did not see #66 before i pushed this.
now i feel silly :D

feel free to close this in favor of that one

@es-sai-fi
Copy link
Copy Markdown

ah, i did not see #66 before i pushed this. now i feel silly :D

feel free to close this in favor of that one

Eh this looks like a better way of handling it, though I think you're forgetting the update bot?

@es-sai-fi
Copy link
Copy Markdown

imo the default should be true :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants