fixes #10 Add support for SSO/organization login#12
Closed
seifrajhi wants to merge 37 commits intonilbuild:masterfrom
seifrajhi:master
Closed
fixes #10 Add support for SSO/organization login#12seifrajhi wants to merge 37 commits intonilbuild:masterfrom seifrajhi:master
seifrajhi wants to merge 37 commits intonilbuild:masterfrom
seifrajhi:master
Conversation
Author
|
Author
|
Hello @kamranahmedse, changes are done as asked. |
nilbuild
requested changes
May 16, 2023
Comment on lines
+114
to
+123
| const awsCredentials = fromSSO({ | ||
| profile: profile, | ||
| }); | ||
|
|
||
| const ssoCredentials = new SSOClient({ | ||
| region: region, | ||
| credentials: awsCredentials, | ||
| }); | ||
|
|
||
| const credentials = await ssoCredentials.config.credentials(); |
Owner
There was a problem hiding this comment.
There are TypeScript errors in this section. Type definitions do not seem to match. Can you please have a look?
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
We Would like to be able to get a cost summary of all of the accounts within our AWS Organization account using SSO login
Therefore, we want to use SSO login instead of configuring ~/.aws/credentials file with static credentials
Pull-Request Checklist
mainbranchFixes #0000