Skip to content

Incorrectly parses directories with spaces #108

@dsibilly

Description

@dsibilly

Description

git-standup does not properly handle paths that include spaces in directory names, e.g. /path/to/my awesome stuff/.

Steps to Reproduce

  1. Install git-standup: npm i -g git-standup
  2. Create a git repository in a path that features a space:
$ cd /mnt/external\ drive/
$ mkdir test-repo
$ cd test-repo
$ git init
Initialized empty Git repository in /mnt/external\ drive/test-repo/.git/
  1. Attempt to run git standup:
$ git standup
/usr/local/bin/git-standup: line 251: cd: drive/test-repo: No such file or directory

Expected Behavior: The utility should correctly parse paths with spaces and not assume that spaces will not be used.

Actual Behavior: git-standup appears to split the path of the current working directory on space characters and use the length - 1th element of the split result instead of the entire path.

Reproduces how often: 100%

Additional Information

This issue has been reproduced on CentOS Linux and macOS 10.14 Mojave with git-standup v2.3.1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions