Format WITHIN GROUP expressions #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend the format-clause multimethod to dispatch on the filter keyword - Assign a priority to filter - Define the helper function
redundant threading macro
- Move filter's priority to the custom additions var
scimetfoo
force-pushed
the
within-group
branch
from
6003cb6 to
fe42e77
Compare
scimetfoo
force-pushed
the
within-group
branch
from
fe42e77 to
fae071e
Compare
kitallis
reviewed
Feb 23, 2021
Contributor
kitallis
left a comment
kitallis
left a comment
There was a problem hiding this comment.
This looks good to me logically.
@scimetfoo If you agree with the suggestions from #42 – then feel free to apply them here as well and merge.
…ostgres into filter-clause
kitallis
previously approved these changes
Mar 11, 2021
kitallis
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9