Add Deprecated pragma to Deprecated module #14888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaviss
requested changes
Jul 3, 2020
| ## as it breaks incremental compilations. | ||
| ## Instead the API here needs to be used. | ||
|
|
||
| {.deprecated: "Deprecated since 0.19; Not supported anymore as it breaks incremental compilation.".} |
There was a problem hiding this comment.
Huh? This is not deprecated.
According to the doc comment:
- Collecting compile time information across module boundaries in global variables is deprecated
- This module provides an alternative way to achieve that.
I can see why the documentation is confusing. If you notice the git blame then this module was added with those exact lines, so that rules out the "this module is deprecated" part.
Instead you should clarify the documentation comment above to separate the points correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{.deprecated.}pragma to Deprecated module.0.19but it has no pragma.