Skip to content

Add Deprecated pragma to Deprecated module #14888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Deprecated pragma to Deprecated module #14888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/core/macrocache.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
## as it breaks incremental compilations.
## Instead the API here needs to be used.

{.deprecated: "Deprecated since 0.19; Not supported anymore as it breaks incremental compilation.".}
Copy link
Collaborator

@alaviss alaviss Jul 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? This is not deprecated.

According to the doc comment:

  • Collecting compile time information across module boundaries in global variables is deprecated
  • This module provides an alternative way to achieve that.

I can see why the documentation is confusing. If you notice the git blame then this module was added with those exact lines, so that rules out the "this module is deprecated" part.

Instead you should clarify the documentation comment above to separate the points correctly.


type
CacheSeq* = distinct string
CacheTable* = distinct string
Expand Down