Replace webdriver with halonium

[jyapayne]

I created a library called halonium that is the Nim version of s python selenium. It has the ability to use any of the web drivers and handles errors and thread management. I think it makes sense to use it here vs webdriver due to the current situation with Firefox having a bug in version 80 where clicks on popups don't register.

Since halonium can work with any browser, if the tests don't work on one browser, we can run it on any other one.

[jyapayne]

Since these changes only affect testing, I'm going to merge them in without a review since they make testing possible again for me by using createSession(Chrome) because of geckodriver + Firefox's current issues.

[dom96]

Whoa, what, webdriver can also work with any browser (and from what I can see the support is definitely there for even Chrome nowadays). Furthermore, I specifically implemented it as it is the next thing which is getting adoption by all the major vendors: https://github.com/w3c/webdriver#vendor-status-documents.

I really wish you didn't just merge this without review. Quite frustrating to see from my perspective. Please do not do this sort of thing. I'm afraid that I will be reverting this. Replacing the library completely because of one bug is not the way to go, and webdriver is signficantly smaller than halonium, the less complexity the better especially when it comes to testing.

[jyapayne]

I didn't mean to offend you and I apologize for merging without review, but I thought it would be okay since this doesn't affect anything besides tests. I won't do it again, but I would ask you to consider adding halonium because I wrote it to also follow the webdriver standard and I think having more options to run the tests is a good thing when issues like this pop up.

[dom96]

No harm done, I probably overreacted to be fair. Sorry about that!

But I'm still not sure what Halonium brings over the plain webdriver, browser support seems to be basically on par for both.

[jyapayne]

No worries. I overstepped a bit as well :)

True. Mainly halonium manages all of subprocess communication so you don't have to worry about it and also provides some of the convenience procs that I wrote for this repo in the common.nim file.

[jyapayne]

I was originally going to extend your webdriver project, but I figured the two projects had different goals. Yours is meant to be a lean interface and I wanted mine to be all inclusive.