Add info to Rcpp plugins to support TBB when creating packages#140
Add info to Rcpp plugins to support TBB when creating packages#140paciorek wants to merge 2 commits into
Conversation
when creating packages (issue #127)
|
@perrydv and I discussed this. This PR needs to be revisited in light of the Rcpp plugin probably not being used / easy to use. Instead, handle in cppDefs by conditionally including the include director if TBB used. We can know this by putting info in auxEnv when we detect use of TBB. |
in cppDef processing, not via Rcpp plugin.
|
@perrydv I have this working by inserting a conditional into However, if I compile two nClasses together, one that uses TBB and one that doesn't, the preamble for the .h files for both classes have Thoughts on whether this is ok? Presumably so since you set it up so that we don't have different preambles for different code files... |
|
Also if you are looking at the code changes, see what you think about the organization of where I inserted the addition to Hpreamble. |
This addresses issue #127.
I think this is fine to merge in, but we should discuss the comment in the issue about
$envseemingly not affecting how a generated package is built/installed to see if there is more work to do around the Rcpp plugins.