Skip to content

Robustify nFunction to handle 0-length name arg #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perrydv merged 1 commit into from
May 11, 2026
Merged

Robustify nFunction to handle 0-length name arg #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nCompiler/R/NF.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ nFunction <- function(fun,
# ADfun: should become AD_nFun
###

if(missing(name))
if(missing(name) || !length(name)) # Check for empty `name` per issue 162.
name <- nFunctionLabelMaker()
## Create internals that will be used for compilation.
internals <- NF_InternalsClass$new(fun,
Expand Down
2 changes: 1 addition & 1 deletion nCompiler/tests/testthat/nimble_tests/test-compileNimble.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ test_that("compileNimble bridge works for one nimbleFunction object", {
run = function() {return(x[1]); returnType(double())}
)
nf1 <- nf()
Cnf1 <- compileNimble(nf1)
Cnf1 <- `:::`("nCompiler", "compileNimble")(nf1)
expect_identical(Cnf1$x, 1:2)
})
## NEXT STEPS:
Expand Down