Include secondary processing of "split" LHSinferred nodes in getImmediateParentNodes #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1511
getImmediateParentNodesis called from only one place,makeModelDerivsInfo. It's all described in #1511.The solution taken here is to extend
getImmediateParentNodesby checking if any returned nodes contain the"%.s%"special syntax, and if so use the element IDs and element names to back to the original elements. This is the first option described in #1511.This should not affect other situations (except for the cost of always calling
greplon the vector of returned nodes), and after all it took years before this bug surfaced, so presumably the cases where it matters are rare.