Skip to content

Rename neededRCfuns field to NeededTypes#322

Closed
fritzo wants to merge 1 commit intodevelfrom
rename-neededrcfuns
Closed

Rename neededRCfuns field to NeededTypes#322
fritzo wants to merge 1 commit intodevelfrom
rename-neededrcfuns

Conversation

@fritzo
Copy link
Copy Markdown
Contributor

@fritzo fritzo commented May 3, 2017

This change was recommended by @perrydv . Perry is this what you intended?

@fritzo fritzo requested a review from perrydv May 3, 2017 17:22
@perrydv
Copy link
Copy Markdown
Contributor

perrydv commented May 3, 2017

Yes, that was the idea, so it can be used more generically like the neededTypes in the nfProcessing class. But let's discuss to get our workflow clear.

@fritzo
Copy link
Copy Markdown
Contributor Author

fritzo commented May 4, 2017

Closing since there is already a field named neededTypes, and I don't understand what this PR intends to do.

@fritzo fritzo closed this May 4, 2017
@fritzo fritzo deleted the rename-neededrcfuns branch May 4, 2017 18:51
@perrydv
Copy link
Copy Markdown
Contributor

perrydv commented May 4, 2017

Makes sense to close this. But the neededTypes exists in nfProcessing and neededRCfuns in RCfunProcessing, so they're in different places. nfProcessing has several different types it might need, hence the generic label "neededTypes". In the past, RCfunProcessing would only need other RCfuns, hence the narrower name neededRCfuns. now (soon) RCfuns can also need nimbleList types, hence the suggested name change. However it is a very minor point and most naturally dealt with in the nimbleList modifications going on right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants