Cashlink Receiving #349
Merged
Cashlink Receiving #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nibhar
force-pushed
the
soeren/cashlink-receive
branch
from
063cd06 to
0701f06
Compare
nibhar
force-pushed
the
soeren/cashlink-receive
branch
5 times, most recently
from
1a77ff8 to
078c3af
Compare
nibhar
force-pushed
the
soeren/cashlink-receive
branch
from
078c3af to
c0e6cbf
Compare
nibhar
approved these changes
Nov 27, 2019
Member
nibhar
left a comment
nibhar
left a comment
There was a problem hiding this comment.
Some unrelated changes.
I pushed a commit on top to change a couple of smaller things, please take a look.
| } | ||
|
|
||
| if (Config.reportToSentry) { | ||
| // initSentry({ |
Member
There was a problem hiding this comment.
I assume this is going to replace VueRaven at a later point? If not it can be removed alongside the imports.
Member
Author
danimoh
requested changes
Nov 27, 2019
danimoh
reviewed
Nov 29, 2019
danimoh
reviewed
Nov 29, 2019
Member
|
|
Member
Author
|
@danimoh The misaligned cashlink icon is already fixed in this PR by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for the Cashlink Receiving UI. It works together with the Cashlink Creation and Management UI in the other PR from Sebastian.
I have tested both the other PR and this PR together (i.e. creating a cashlink in the other branch and claiming it in this branch) and it worked beautifully!
Auto-approve, anyone? 😄