fix(about): readable Education headings (text-base color collision)#4
Merged
Conversation
The degree/institution <h3>s used `text-base`, which emits both a font-size AND `color: #0E0E10` because the palette's `base` color shares Tailwind's default `base` font-size key. `sm:text-lg` overrode the size but not the leaked color, rendering the headings invisible (black on the near-black background). Drop `text-base` so the heading inherits `ink` and sizes via `sm:text-lg`. Add e2e/about-readability.spec.ts: a real-browser contrast guard (jsdom can't see the cascade; axe marks it "incomplete" because the .grain overlay defeats its background detection). Closes #3 partially — the underlying token collision is tracked there for a design-token rename.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Education degree/institution
<h3>s usedtext-base, which emitted both a font-size andcolor: #0E0E10— because the palette defines abasecolor andbaseis also Tailwind's default font-size key.sm:text-lgoverrode the size but not the leaked color, leaving the headings black-on-near-black (invisible).Fix: drop
text-baseso the heading inheritsinkand sizes viasm:text-lg.Tests
Adds
e2e/about-readability.spec.ts— a real-browser contrast guard. jsdom can't see the cascade and axe marks it "incomplete" (the.grainoverlay defeats its background detection), so an explicit Playwright contrast check is the only reliable regression guard.Notes
Split out of #2 (CI pipeline) so the design fix isn't gated behind CI review. Partially addresses #3 — the underlying
basetoken collision (design-token rename) is still tracked there.