Fix: Use raw tags for paths and links for GitHub Pages#3
Merged
Conversation
This is my third attempt to resolve 404 errors for tags with Japanese characters on GitHub Pages. I'm basing this on your feedback indicating that URLs are being resolved to a raw (decoded) form with a trailing slash (e.g., /tags/未AC/). This commit implements the following strategy: 1. Ensures `trailingSlash: true` in `next.config.ts` to support `directory/index.html` structures. 2. Configures `generateStaticParams` in `src/app/tags/[tag]/page.tsx` to use raw (decoded) tag names for path generation. This should result in Next.js creating directories with names like `out/tags/未AC/index.html`. 3. Updates the `TagPage` component in `src/app/tags/[tag]/page.tsx` to expect these raw tag names as parameters. 4. Modifies the link generation in `src/app/tags/page.tsx` to use raw (decoded) tag names in the `href` attributes of `Link` components. This ensures that generated links match the directory structure (e.g., `/tags/未AC`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my third attempt to resolve 404 errors for tags with Japanese characters on GitHub Pages. I'm basing this on your feedback indicating that URLs are being resolved to a raw (decoded) form with a trailing slash (e.g., /tags/未AC/).
This commit implements the following strategy:
trailingSlash: trueinnext.config.tsto supportdirectory/index.htmlstructures.generateStaticParamsinsrc/app/tags/[tag]/page.tsxto use raw (decoded) tag names for path generation. This should result in Next.js creating directories with names likeout/tags/未AC/index.html.TagPagecomponent insrc/app/tags/[tag]/page.tsxto expect these raw tag names as parameters.src/app/tags/page.tsxto use raw (decoded) tag names in thehrefattributes ofLinkcomponents. This ensures that generated links match the directory structure (e.g.,/tags/未AC).