Do not trigger numpy import when converting non-numpy python objects to java #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents jep from importing numpy if it isn't already imported into an interpreter. It is especially important for anyone who builds jep with numpy support and wants to use isolated sub-interpreters. Numpy does not work in isolated sub-interpreters so jep should not ever import it. It should still be possible to use the same build of Jep with numpy support in shared interpreters.
Without this change TestIsolatedSubInterpreter.java will fail when jep is built with numpy support so new testing is not needed, our existing test verify this change whenever jep is built with numpy support.