Skip to content

Removed \x90 rx.frame_id, added one byte to rx.source_address length#41

Merged
mattdodge merged 1 commit intoniolabs:masterfrom
BenTheNinjaRock:master
Apr 3, 2017
Merged

Removed \x90 rx.frame_id, added one byte to rx.source_address length#41
mattdodge merged 1 commit intoniolabs:masterfrom
BenTheNinjaRock:master

Conversation

@BenTheNinjaRock
Copy link
Copy Markdown
Contributor

\x90 has no frame_id as far as I can tell

@jamesleesaunders
Copy link
Copy Markdown
Collaborator

jamesleesaunders commented Apr 2, 2017

Hi Ben,
Thanks for contributing! Looking at the 'Receive Packet Frame 0x90' spec at https://www.digi.com/resources/documentation/digidocs/pdfs/90000991.pdf (Page 133) it looks like you are right:

Frame data fields Offset Description
Frame type 3 0x90
64-bit source address 4-11 The sender's 64-bit address. MSB first, LSB last.
Reserved 12-13 Reserved.
Receive options 14 Bit field: 0x01/0x02.
Received data 15-n The RF data the device receives.

I have no way to test this but @luk156 and @thom-nic are the original contributors of the DigiMesh class I don't know if they have any other comments? But all looks good to me, I will leave it to the guys nioinnovation to give the final PR approval.

@BenTheNinjaRock
Copy link
Copy Markdown
Contributor Author

No problem, glad to hear you agree! I've been using the altered code for a while and seems to work fine, but did want to check just to make sure.

@thom-nic
Copy link
Copy Markdown

thom-nic commented Apr 3, 2017

LGTM

@mattdodge mattdodge merged commit 4ca6615 into niolabs:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants