Skip to content

Adding missing request frames as per XBEE docs#43

Merged
jamesleesaunders merged 2 commits intoniolabs:masterfrom
mlasevich:master
Apr 15, 2017
Merged

Adding missing request frames as per XBEE docs#43
jamesleesaunders merged 2 commits intoniolabs:masterfrom
mlasevich:master

Conversation

@mlasevich
Copy link
Copy Markdown
Contributor

Adding the missing requests needed to use source routes

@jamesleesaunders
Copy link
Copy Markdown
Collaborator

Thanks for contributing and adding two more frame types defs for create_source_route and register_joining_device, good stuff!

I think it may be a good idea to add to the README a list of supported and not yet implemented frame types, in the same way our Node.js cousin does here:
https://github.com/jankolkmeier/xbee-api/blob/master/README.md
Not only would this help people know what is supported, but it may also encourage people to contribute like you have @mlasevich.

Thanks again!

@jamesleesaunders jamesleesaunders merged commit 56699b1 into niolabs:master Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants