Fix Issue #45 DigiMesh Python 3 Support#46
Merged
Conversation
…hey are currently strings and not bytes.
Collaborator
Author
|
@hansmosh @mattdodge Bugfix PR to review if you could? |
mattdodge
approved these changes
Apr 25, 2017
Collaborator
mattdodge
left a comment
mattdodge
left a comment
There was a problem hiding this comment.
Looks great, thanks @jamesleesaunders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #45 For Python3 the digimesh module fails if given the defaults because they are currently strings and not bytes. This PR fixes this.