Fix for Issue #50 Python3 Fix in _build_command()#51
Merged
Conversation
Collaborator
Author
|
@hansmosh @mattdodge Please could one of you give this a check over? I didn't want to merge this in until at least one of you had given it a look. I have written a test (albeit not sure in the right place?) |
mattdodge
approved these changes
Jun 13, 2017
Collaborator
mattdodge
left a comment
There was a problem hiding this comment.
LGTM, thanks @jamesleesaunders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running code:
Running on python3 causes error:
Caused because _build_command() tries to concat bytes with at command 'MY' of type string.
This solution proposes checking data type and converting to bytes.
Also written a small unit test to make sure now works. I am not totally sure if test_zigbee.py is the most appropriate place for it.
Fixes Issue #50